+1. Thanks Fokko. Best, Honah
On Tue, Nov 19, 2024 at 9:11 AM Kevin Liu <kevin.jq....@gmail.com> wrote: > +1 (non-binding). The spec and code deprecation schedule looks good to me. > > Best, > Kevin Liu > > On Tue, Nov 19, 2024 at 8:42 AM Christian Thiel > <christ...@hansetag.com.invalid> wrote: > >> +1 (non-binding) – looks like we are going in the right direction in rust! >> >> >> Christian >> >> >> On 19. Nov 2024, at 16:13, Jack Ye <yezhao...@gmail.com> wrote: >> >> +1 >> >> -Jack >> >> On Tue, Nov 19, 2024 at 7:45 AM Russell Spitzer < >> russell.spit...@gmail.com> wrote: >> >>> +1 >>> >>> On Tue, Nov 19, 2024 at 4:11 AM Fokko Driesprong <fo...@apache.org> >>> wrote: >>> >>>> Hey Manu, >>>> >>>> That's an excellent question. I took the following rationale: >>>> >>>> - For the code, the iceberg-core module, a minor release >>>> deprecation cycle is required >>>> <https://iceberg.apache.org/contribute/#semantic-versioning>. >>>> - For the spec, I noticed that the deprecation of the >>>> >>>> <https://github.com/apache/iceberg/blob/7af519ad5df13256fda480cc31e975e63dd8763b/open-api/rest-catalog-open-api.yaml#L186-L187> >>>> getToken >>>> >>>> <https://github.com/apache/iceberg/blob/7af519ad5df13256fda480cc31e975e63dd8763b/open-api/rest-catalog-open-api.yaml#L186-L187> >>>> endpoint >>>> >>>> <https://github.com/apache/iceberg/blob/7af519ad5df13256fda480cc31e975e63dd8763b/open-api/rest-catalog-open-api.yaml#L186-L187> >>>> was >>>> set for removal in 2.0, so that's what I took for the last-column-id PR >>>> as well. >>>> >>>> To conclude: both spec and code will be deprecated in the following >>>> minor release (1.8.x), the removal from the code is staged for the next >>>> minor (1.9.x) or major release (2.x.x), and the removal from the spec is >>>> planned for (2.x.x). Hope this clarifies. >>>> >>>> Kind regards, >>>> Fokko Driesprong >>>> >>>> Op di 19 nov 2024 om 10:45 schreef Manu Zhang <owenzhang1...@gmail.com >>>> >: >>>> >>>>> Thanks Fokko. >>>>> >>>>> To be clear, are you proposing to deprecate last-column-id in 1.8.0 >>>>> and remove in 1.9.0+? >>>>> >>>>> On Tue, Nov 19, 2024 at 4:18 PM Fokko Driesprong <fo...@apache.org> >>>>> wrote: >>>>> >>>>>> Hi everyone, >>>>>> >>>>>> Based on the positive feedback on the [DISCUSS] thread >>>>>> <https://lists.apache.org/thread/jz5s7pm2bhbm87ft495d6yrsh3bqvtb9> and >>>>>> the pull-request on GitHub >>>>>> <https://github.com/apache/iceberg/pull/11514/>, I would like to >>>>>> raise a vote to deprecate and remove the last-column-id field from the >>>>>> spec. Since this is a spec change, please vote in the next 72 hours: >>>>>> >>>>>> [ ] +1, commit the proposed spec changes >>>>>> [ ] 0 >>>>>> [ ] -1, do not make these changes because... >>>>>> >>>>>> Kind regards, >>>>>> Fokko >>>>>> >>>>> >>
