Thanks everyone! The vote has been passed with 4 binding votes, and 8 non-binding votes.
I'll go ahead to work with Renjie to finalize the release of Apache Iceberg C++ 0.1.0. We will address all the feedback above after release. Best, Gang On Sat, Sep 13, 2025 at 10:30 PM Fokko Driesprong <fo...@apache.org> wrote: > +1 (binding) > > Exciting to see the first release, thanks to everyone who was involved in > this effort :) > > - Checked license, signatures, and checksums > - Did some manual checks in the code, and it looks good. > - I think there is some inconsistency in the LICENSE > <https://github.com/apache/iceberg-cpp/blob/b717675f6e82d5c87a5468093f1112d03cf677f8/LICENSE#L245-L255>, > where it calls out files that are borrowed from Arrow. I think there are a > few more in the source dist, for example, IcebergBuildUtils.cmake > <https://github.com/apache/iceberg-cpp/blob/main/cmake_modules/IcebergBuildUtils.cmake#L18-L19>. > Since this is called out explicitly in the file itself, I think we're good, > but it would be good to keep this in sync. > > Kind regards, > Fokko > > Op za 13 sep 2025 om 16:17 schreef Gang Wu <ust...@gmail.com>: > >> To Yufei: >> >> Yes, Renjie helped us run the release script so it is signed by him. >> (Thanks Renjie!) >> >> On Sat, Sep 13, 2025 at 12:13 PM Steven Wu <stevenz...@gmail.com> wrote: >> >>> +1 (binding) >>> >>> verified signature, checksum >>> Ran dev/release/verify_rc.sh 0.1.0 4 successfully >>> Manually checked the LICENSE and NOTICE files at root directory. >>> >>> Env >>> - Mac OS 15.6.1, M3 Max >>> - cmake 4.1.1 >>> - Apple clang 17.0.0 (arm64) >>> >>> On Fri, Sep 12, 2025 at 9:50 AM Yufei Gu <flyrain...@gmail.com> wrote: >>> >>>> Hi Gang, thanks for doing this! >>>> >>>> +1(binding) >>>> >>>> 1. Verified the signature >>>> 2. Verified the checksum >>>> 3. Build and test passed(cmake 4.1.1 on MacOS 15.6.1) >>>> >>>> One minor thing is that the signature is with Renjie. Is Renjie the >>>> release manager? Or just his key was used. >>>> >>>> gpg: assuming signed data in 'apache-iceberg-cpp-0.1.0.tar.gz' >>>> gpg: Signature made Wed Sep 10 04:58:28 2025 CDT >>>> gpg: using RSA key >>>> F3148372ECE8B527A79EAECC89B4D070F9510B1E >>>> gpg: Good signature from "Renjie Liu <liurenjie1...@apache.org>" >>>> [unknown] >>>> gpg: WARNING: This key is not certified with a trusted signature! >>>> gpg: There is no indication that the signature belongs to the >>>> owner. >>>> Primary key fingerprint: F314 8372 ECE8 B527 A79E AECC 89B4 D070 F951 >>>> 0B1E >>>> >>>> Yufei >>>> >>>> >>>> On Thu, Sep 11, 2025 at 8:04 AM Renjie Liu <liurenjie2...@gmail.com> >>>> wrote: >>>> >>>>> +1 binding >>>>> >>>>> I did following check >>>>> - Verified signature >>>>> - Verified checksum >>>>> - Run test/build command following instructions >>>>> <https://github.com/apache/iceberg-cpp?tab=readme-ov-file#build-run-test-and-install-core-libraries> >>>>> >>>>> >>>>> I didn't run a check to verify the license because it's verified in ci. >>>>> >>>>> Environment: >>>>> Macos 15.6.1 M4 Pro >>>>> cmake 4.1.1 >>>>> Apple clang version 17.0.0 (clang-1700.0.13.5) >>>>> >>>>> On Thu, Sep 11, 2025 at 1:28 PM Gang Wu <ust...@gmail.com> wrote: >>>>> >>>>>> To Steven: >>>>>> >>>>>> Yes, please check the Audit section from >>>>>> https://github.com/apache/iceberg-cpp/actions/runs/17609907663/job/50029231341 >>>>>> >>>>>> It ran >>>>>> https://github.com/apache/iceberg-cpp/blob/main/dev/release/run_rat.sh >>>>>> under the hood. >>>>>> >>>>>> >>>>>> >>>>>> On Thu, Sep 11, 2025 at 1:23 PM Steven Wu <stevenz...@gmail.com> >>>>>> wrote: >>>>>> >>>>>>> Does the release check script run RAT checks on license headers? >>>>>>> >>>>>>> On Wed, Sep 10, 2025 at 9:16 PM ying cai <ying.cai...@gmail.com> >>>>>>> wrote: >>>>>>> >>>>>>>> +1 (non-binding) >>>>>>>> >>>>>>>> Ran dev/release/verify_rc.sh 0.1.0 4 successfully on apple m1 >>>>>>>> macOS 15.6.1 with clang 19.1.7. >>>>>>>> Verified checksums and signatures, also checked the build and tests. >>>>>>>> >>>>>>>> Thanks for working on this. >>>>>>>> >>>>>>>> Best, >>>>>>>> Ying >>>>>>>> >>>>>>>> On Thu, Sep 11, 2025 at 9:39 AM 于国涛 <guotao.y...@gmail.com> wrote: >>>>>>>> >>>>>>>>> +1 (non-binding) >>>>>>>>> >>>>>>>>> Verified checksums and signatures, >>>>>>>>> ran dev/release/verify_rc.sh 0.1.0 4 successfully >>>>>>>>> and checked the build and tests on macOS 14.5. >>>>>>>>> >>>>>>>>> >>>>>>>>> Regards >>>>>>>>> Guotao Yu >>>>>>>>> >>>>>>>>> 在 2025年9月10日 18:08:04 上，Gang Wu <ust...@gmail.com> 写道： >>>>>>>>> >>>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> I would like to propose the following release candidate (RC4) of >>>>>>>>>> Apache Iceberg >>>>>>>>>> C++ version 0.1.0. This is the first ever release of Apache >>>>>>>>>> Iceberg for C++, >>>>>>>>>> highlights include: >>>>>>>>>> >>>>>>>>>> - Core Metadata: Implementation of the fundamental Iceberg data >>>>>>>>>> model, including >>>>>>>>>> schemas, partition specs, and table metadata, with full JSON >>>>>>>>>> serialization >>>>>>>>>> support. >>>>>>>>>> - File I/O and Formats: A pluggable FileIO interface with initial >>>>>>>>>> support for >>>>>>>>>> local filesystems, along with readers and writers for Avro and >>>>>>>>>> Parquet. >>>>>>>>>> - Table API: A basic Table interface supporting metadata >>>>>>>>>> operations and scan >>>>>>>>>> planning, accompanied by an in-memory catalog for development >>>>>>>>>> and testing. >>>>>>>>>> >>>>>>>>>> This release marks a significant milestone, thanks everyone who >>>>>>>>>> has contributed >>>>>>>>>> and community members who have helped along the way! >>>>>>>>>> >>>>>>>>>> This release candidate is based on commit: >>>>>>>>>> b717675f6e82d5c87a5468093f1112d03cf677f8 [1]. >>>>>>>>>> >>>>>>>>>> The source release is hosted at [2]. >>>>>>>>>> >>>>>>>>>> Please download, verify checksums and signatures, run the unit >>>>>>>>>> tests, >>>>>>>>>> and vote on the release. See [3] for how to validate a release >>>>>>>>>> candidate. >>>>>>>>>> >>>>>>>>>> The vote will be open for at least 72 hours. >>>>>>>>>> >>>>>>>>>> [ ] +1 Release this as Apache Iceberg C++ 0.1.0 >>>>>>>>>> [ ] +0 >>>>>>>>>> [ ] -1 Do not release this as Apache Iceberg C++ 0.1.0 because... >>>>>>>>>> >>>>>>>>>> [1]: >>>>>>>>>> https://github.com/apache/iceberg-cpp/tree/b717675f6e82d5c87a5468093f1112d03cf677f8 >>>>>>>>>> [2]: >>>>>>>>>> https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-cpp-0.1.0-rc4 >>>>>>>>>> [3]: >>>>>>>>>> https://github.com/apache/iceberg-cpp/blob/main/dev/release/README.md#verify >>>>>>>>>> >>>>>>>>>> Best, >>>>>>>>>> Gang >>>>>>>>>> >>>>>>>>>
