+1 binding I did following check - Verified signature - Verified checksum - Run test/build command following instructions <https://github.com/apache/iceberg-cpp?tab=readme-ov-file#build-run-test-and-install-core-libraries>
I didn't run a check to verify the license because it's verified in ci. Environment: Macos 15.6.1 M4 Pro cmake 4.1.1 Apple clang version 17.0.0 (clang-1700.0.13.5) On Thu, Sep 11, 2025 at 1:28 PM Gang Wu <ust...@gmail.com> wrote: > To Steven: > > Yes, please check the Audit section from > https://github.com/apache/iceberg-cpp/actions/runs/17609907663/job/50029231341 > > It ran > https://github.com/apache/iceberg-cpp/blob/main/dev/release/run_rat.sh > under the hood. > > > > On Thu, Sep 11, 2025 at 1:23 PM Steven Wu <stevenz...@gmail.com> wrote: > >> Does the release check script run RAT checks on license headers? >> >> On Wed, Sep 10, 2025 at 9:16 PM ying cai <ying.cai...@gmail.com> wrote: >> >>> +1 (non-binding) >>> >>> Ran dev/release/verify_rc.sh 0.1.0 4 successfully on apple m1 macOS >>> 15.6.1 with clang 19.1.7. >>> Verified checksums and signatures, also checked the build and tests. >>> >>> Thanks for working on this. >>> >>> Best, >>> Ying >>> >>> On Thu, Sep 11, 2025 at 9:39 AM 于国涛 <guotao.y...@gmail.com> wrote: >>> >>>> +1 (non-binding) >>>> >>>> Verified checksums and signatures, >>>> ran dev/release/verify_rc.sh 0.1.0 4 successfully >>>> and checked the build and tests on macOS 14.5. >>>> >>>> >>>> Regards >>>> Guotao Yu >>>> >>>> 在 2025年9月10日 18:08:04 上,Gang Wu <ust...@gmail.com> 写道: >>>> >>>>> Hi, >>>>> >>>>> I would like to propose the following release candidate (RC4) of >>>>> Apache Iceberg >>>>> C++ version 0.1.0. This is the first ever release of Apache Iceberg >>>>> for C++, >>>>> highlights include: >>>>> >>>>> - Core Metadata: Implementation of the fundamental Iceberg data model, >>>>> including >>>>> schemas, partition specs, and table metadata, with full JSON >>>>> serialization >>>>> support. >>>>> - File I/O and Formats: A pluggable FileIO interface with initial >>>>> support for >>>>> local filesystems, along with readers and writers for Avro and >>>>> Parquet. >>>>> - Table API: A basic Table interface supporting metadata operations >>>>> and scan >>>>> planning, accompanied by an in-memory catalog for development and >>>>> testing. >>>>> >>>>> This release marks a significant milestone, thanks everyone who has >>>>> contributed >>>>> and community members who have helped along the way! >>>>> >>>>> This release candidate is based on commit: >>>>> b717675f6e82d5c87a5468093f1112d03cf677f8 [1]. >>>>> >>>>> The source release is hosted at [2]. >>>>> >>>>> Please download, verify checksums and signatures, run the unit tests, >>>>> and vote on the release. See [3] for how to validate a release >>>>> candidate. >>>>> >>>>> The vote will be open for at least 72 hours. >>>>> >>>>> [ ] +1 Release this as Apache Iceberg C++ 0.1.0 >>>>> [ ] +0 >>>>> [ ] -1 Do not release this as Apache Iceberg C++ 0.1.0 because... >>>>> >>>>> [1]: >>>>> https://github.com/apache/iceberg-cpp/tree/b717675f6e82d5c87a5468093f1112d03cf677f8 >>>>> [2]: >>>>> https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-cpp-0.1.0-rc4 >>>>> [3]: >>>>> https://github.com/apache/iceberg-cpp/blob/main/dev/release/README.md#verify >>>>> >>>>> Best, >>>>> Gang >>>>> >>>>