-1 (non-binding)
Disclaimer this was found after prompting my Claude to validate all the licenses for this RC.
Reason: iceberg-gcp-bundle-1.12.0.jar bundles Caffeine with no entry in its LICENSE. Details below. Everything else checked out.
Verified:
- sha512 and GPG signature (Amogh Jahagirdar's key from KEYS)
- source tarball matches the apache-iceberg-1.12.0-rc1 tag apart from the generated iceberg-build.properties and version.txt, and contains no compiled artifacts
- LICENSE and NOTICE, dev/check-license (RAT)
- staged binaries in orgapacheiceberg-1285: signatures on the 12 runtime and bundle jars, each jar's LICENSE and NOTICE against the source module, and the third-party packages inside each jar against its LICENSE entries
- ./gradlew build with tests on three Linux environments:
- Amazon Linux 2023 x86_64, Corretto 21.0.12.1
Finding:
iceberg-gcp-bundle-1.12.0.jar bundles Caffeine (718 classes under com/github/benmanes/caffeine) and gcp-bundle/LICENSE has no entry for it. Caffeine arrives through com.google.cloud.gcs.analytics:common 1.5.0, pulled in by the gcs-analytics-core bump in #17687. The 1.2.3 version that 1.11.0 used did not depend on Caffeine, and gcp-bundle/LICENSE is unchanged since 1.11.0, so this is new in 1.12.0. Caffeine is Apache 2.0, so nothing is incompatible, but the bundle's LICENSE has to list what the jar ships. aws-bundle/LICENSE already carries the entry to copy, so the fix is a few lines in gcp-bundle/LICENSE.
Issue: https://github.com/apache/iceberg/issues/18217 PR: https://github.com/apache/iceberg/pull/18218
Additional Non-Blocking Findings:
RCK test failures with org.gradle.parallel=true and docker compose available, :iceberg-open-api:test can start while the kafka-connect integration stack holds host port 8181, and the REST Compatibility Kit server then fails to bind. Both use the fixed port 8181.
Issue: https://github.com/apache/iceberg/issues/18215
PR: https://github.com/apache/iceberg/pull/18216
- Kurtis +1
Passed: GPG signature, SHA-512, announced commit/tag, and license/RAT checks.Core tests: 8,400 passed, 550 skipped, zero failures.Spark test: passed using a Spark 4.2 built from verified RC0 source.
I'm unable to access the staged binaries at the moment, so built from source.
ThanksSzehonHi
Like the other one, its a pre-existing issue and maybe not worth to stop this RC, but just another one to add to Gianluca's list.
Thanks, Szehon
Thanks for raising that Gianluca. Since the issue isn't exactly a regression and constrained to the version of the commons-lang3, I think we can make a patch into the respective branches. I tried a local fix but want to make sure it can be tested well before making it into a fix. I'll follow up after the release to see how to get a proper fix in.
+1 (non-binding)
Verified checksums, signature, source archive vs. tag, RAT, and ran
smoke tests with the staged Spark 4.0 runtime.
Already mentioned for RC0: I hit a pre-existing NoSuchMethodError when reading variant columns with commons-lang3 < 3.13 on the classpath. iceberg-parquet uses Streams.of(Iterable) without declaring the dependency.
This is also present in 1.11.0, so it’s not a regression. The issue is tracked here: https://github.com/apache/iceberg/issues/18164 (PR ready).
If there’s a new RC, please consider including the fix. It’s not impactful enough to block the release process.
Cheers,
Gianluca
On 2026/09/22 03:35:41 Neelesh Salian wrote:
> Hi Everyone,
>
> I propose that we release the following RC as the official Apache Iceberg
> 1.12.0 release.
>
> The commit ID is e8d0f0f3004a608e45986cbc2f8e5baf1a8a7db9
> * This corresponds to the tag: apache-iceberg-1.12.0-rc1
> * https://github.com/apache/iceberg/commits/apache-iceberg-1.12.0-rc1
> *
> https://github.com/apache/iceberg/tree/e8d0f0f3004a608e45986cbc2f8e5baf1a8a7db9
>
> The release tarball, signature, and checksums are here:
> * https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-1.12.0-rc1
>
> You can find the KEYS file here:
> * https://downloads.apache.org/iceberg/KEYS
>
> Convenience binary artifacts are staged on Nexus. The Maven repository URL
> is:
> * https://repository.apache.org/content/repositories/orgapacheiceberg-1285/
>
> Please download, verify, and test.
>
> Instructions for verifying a release can be found here:
> * https://iceberg.apache.org/how-to-release/#how-to-verify-a-release
>
> Please vote in the next 72 hours.
>
> [ ] +1 Release this as Apache Iceberg 1.12.0
> [ ] +0
> [ ] -1 Do not release this because...
>
> Only PMC members have binding votes, but other community members are
> encouraged to cast
> non-binding votes. This vote will pass if there are 3 binding +1 votes and
> more binding
> +1 votes than -1 votes.
>
|
