Ok, I will fix trivial issues and prepare report for most suspicious code. On Tue, Nov 24, 2015 at 4:34 PM, Yakov Zhdanov <[email protected]> wrote:
> Alex, if you have already run this test, can you please share the report > or, even more, fix vivid trivial issues right away and let us review? > > --Yakov > > 2015-11-24 6:50 GMT+03:00 Alexey Kuznetsov <[email protected]>: > > > Igniters, > > > > I've installed FindBugs plugin for Idea and run it on ignite-core module. > > > > Well it found a lot... 1331 items... > > > > Some of them are false-positive of course, but this plugin has quite > handy > > grouping > > and we could only check important groups like "Multithreading". > > > > > > Also FindBugs found a bunch of silly bugs like this in GridCacheAdapter: > > --------------- > > Nullcheck of res at line 5936 of value previously dereferenced > > > > for (ComputeJobResult res : results) { > > line 5936 >>> if (res.getException() == null && res != null) > > size += res.<Integer>getData(); > > } > > --------------- > > > > I think it is worth to install this plugin and take a look. > > > > -- > > Alexey Kuznetsov > > GridGain Systems > > www.gridgain.com > > > -- Alexey Kuznetsov GridGain Systems www.gridgain.com
