Cos, that was only ONE module checked :)
And who knows what FindBugs will find when I start it over whole project.
:)
On Thu, Nov 26, 2015 at 9:31 AM, Konstantin Boudnik <c...@apache.org> wrote:
> On Tue, Nov 24, 2015 at 10:50AM, Alexey Kuznetsov wrote:
> > Igniters,
> >
> > I've installed FindBugs plugin for Idea and run it on ignite-core module.
> >
> > Well it found a lot... 1331 items...
>
> Better than 100500, eh? :)
>
> > Some of them are false-positive of course, but this plugin has quite
> handy
> > grouping
> > and we could only check important groups like "Multithreading".
> >
> >
> > Also FindBugs found a bunch of silly bugs like this in GridCacheAdapter:
> > ---------------
> > Nullcheck of res at line 5936 of value previously dereferenced
> >
> > for (ComputeJobResult res : results) {
> > line 5936 >>> if (res.getException() == null && res != null)
> > size += res.<Integer>getData();
> > }
> > ---------------
> >
> > I think it is worth to install this plugin and take a look.
> >
> > --
> > Alexey Kuznetsov
> > GridGain Systems
> > www.gridgain.com
>
--
Alexey Kuznetsov
GridGain Systems
www.gridgain.com
