Folks, DML is merged to ignite-1.8, but according to JIRA reports several problems with it were revealed. I propose to focus on DML finalization in ignite-1.8 branch, and minimize other merges to it, targeting them for the next release (1.9, 2.0?).
Any objections? Vladimir. On Wed, Nov 23, 2016 at 7:25 PM, Igor Sapego <[email protected]> wrote: > Denis, > > I've raised PRs and Vladimir has merged them into ignite-1.8. But now we > have some > failing ODBC tests in the branch. I'm currently working on them. There is a > ticket for > that which you can track [1]. I'll add all my findings there. > > [1] https://issues.apache.org/jira/browse/IGNITE-4288 > > Best Regards, > Igor > > On Wed, Nov 23, 2016 at 7:08 PM, Denis Magda <[email protected]> wrote: > > > Alexander, > > > > Awesome news, thanks for making this happen! > > > > Igor S., have you merged all ODBC-DML-PHP/PDO related changes? Can I > start > > testing that PHP-PDO guidance [1] is correct? > > > > [1] https://apacheignite.readme.io/docs/pdo-interoperability < > > https://apacheignite.readme.io/docs/pdo-interoperability> > > > > — > > Denis > > > > > On Nov 23, 2016, at 12:01 AM, Alexander Paschenko < > > [email protected]> wrote: > > > > > > Folks, > > > > > > Yesterday it'd been agreed with Sergi that DML branch is now good to > > > be included into 1.8 branch that is to be created. > > > > > > Minor review fixes, should they be made, and test fixes will be > > > incorporated into 1.8 as separate patches later. > > > > > > Also, it'd been agreed that, in order to deliver these new features on > > > time, two subtasks will be fixed in later releases (shortly): > > > > > > https://issues.apache.org/jira/browse/IGNITE-4268 > > > https://issues.apache.org/jira/browse/IGNITE-4269 > > > > > > On failing tests: > > > https://issues.apache.org/jira/browse/IGNITE-2294? > > focusedCommentId=15683377 > > > > > > - Alex > > > > > > 2016-11-22 11:29 GMT+03:00 Alexander Paschenko > > > <[email protected]>: > > >> Vlad, > > >> > > >> Most likely today. > > >> > > >> - Alex > > >> > > >> 2016-11-22 11:25 GMT+03:00 Vladimir Ozerov <[email protected]>: > > >>> Igniters, > > >>> > > >>> I went through remaining tickets assigned to 1.8 and it seems that we > > are > > >>> pretty close to release. As far as I understand the biggest remaining > > >>> feature is DML [1]. I think we can create separate branch for 1.8 as > > soon > > >>> as it is merged. Alex, do you have any idea on when it might happen? > > >>> > > >>> Vladimir. > > >>> > > >>> [1] https://issues.apache.org/jira/browse/IGNITE-2294 > > >>> > > >>> On Thu, Nov 17, 2016 at 4:06 AM, Denis Magda <[email protected]> > > wrote: > > >>> > > >>>> Roman, > > >>>> > > >>>> That versions will be created after 1.8 gets released. Recently > there > > was > > >>>> a discussion on the dev list [1] regarding the difficulties related > to > > >>>> documentation maintenance when several documentation versions > > co-exist at > > >>>> the same time. > > >>>> > > >>>> It was decided that rather then create a new version for the > > documentation > > >>>> once a new feature added to Ignite it’s better to create a hidden > page > > >>>> under the current documentation version and make it visible once the > > next > > >>>> version is created after the release. > > >>>> > > >>>> The bottom line is that, please create a hidden page with a suffix > > >>>> “page_name-1.8” and once 1.8 gets released Prachi will create > > readme.io < > > >>>> http://readme.io/> 1.8 and make your doc visible. > > >>>> > > >>>> [1] http://apache-ignite-developers.2346864.n4.nabble. > > >>>> com/Maintaining-documentation-consistency-on-readme-io-td10868.html > < > > >>>> http://apache-ignite-developers.2346864.n4.nabble. > > >>>> com/Maintaining-documentation-consistency-on-readme-io- > td10868.html> > > >>>> > > >>>> — > > >>>> Denis > > >>>> > > >>>>> On Nov 16, 2016, at 5:00 PM, Roman Shtykh > <[email protected] > > > > > >>>> wrote: > > >>>>> > > >>>>> Denis, > > >>>>> Any plans to add 1.8.0 in readme.io for new features? > > >>>>> -Roman > > >>>>> On Wednesday, November 16, 2016 6:08 AM, Denis Magda < > > >>>> [email protected]> wrote: > > >>>>> > > >>>>> > > >>>>> Igor, > > >>>>> > > >>>>> It makes sense to wait for me while everything gets merged into 1.8 > > >>>> then. Please let me know over this discussion when the overall merge > > >>>> happens. > > >>>>> > > >>>>> — > > >>>>> Denis > > >>>>> > > >>>>>> On Nov 15, 2016, at 1:45 AM, Igor Sapego <[email protected]> > > wrote: > > >>>>>> > > >>>>>> Denis, > > >>>>>> > > >>>>>> I can merge PDO-related changes into 1.8 but without DML they will > > >>>> break tests > > >>>>>> and even compilation so I don't see any sense in doing that before > > DML > > >>>> is merged. > > >>>>>> > > >>>>>> After DML is ready and merged I'll need some time to merge my > > changes > > >>>> and check > > >>>>>> that everything works as intended. The code itself, tests and > > examples > > >>>> are ready. > > >>>>>> > > >>>>>> > > >>>>>> Best Regards, > > >>>>>> Igor > > >>>>>> > > >>>>>> On Tue, Nov 15, 2016 at 11:31 AM, Pavel Tupitsyn < > > [email protected] > > >>>> <mailto:[email protected]>> wrote: > > >>>>>> Denis, [1] depends on [2], and [2](.NET: CacheEntryProcessor > binary > > >>>> mode) > > >>>>>> is not a simple thing. We won't be able to do that for 1.8. > > >>>>>> Other than that, I'll try to fit as many of them as I can. But I > > can't > > >>>>>> answer your question since I don't see any date yet. > > >>>>>> > > >>>>>> By the way, you were going to help with the reviews. > > >>>>>> > > >>>>>> [1] https://issues.apache.org/jira/browse/IGNITE-4128 < > > >>>> https://issues.apache.org/jira/browse/IGNITE-4128> > > >>>>>> [2] https://issues.apache.org/jira/browse/IGNITE-3825 < > > >>>> https://issues.apache.org/jira/browse/IGNITE-3825> > > >>>>>> > > >>>>>> On Tue, Nov 15, 2016 at 4:03 AM, Denis Magda <[email protected] > > >>>> <mailto:[email protected]>> wrote: > > >>>>>> > > >>>>>>> *Alexander P., Igor S.,* > > >>>>>>> > > >>>>>>> When will your merge all DML and ODBC (PDO) related changes into > > 1.8 > > >>>>>>> branch? I’m looking forward to go through PDO [1] documentation > > and be > > >>>> sure > > >>>>>>> that everything works as described on my side. > > >>>>>>> > > >>>>>>> *Pavel,* > > >>>>>>> > > >>>>>>> Do you think it will be possible to complete all the .NET > usability > > >>>>>>> tickets [2] under 1.8 and roll them out to the Apache Ignite > users? > > >>>>>>> > > >>>>>>> [1] https://issues.apache.org/jira/browse/IGNITE-3921 < > > >>>> https://issues.apache.org/jira/browse/IGNITE-3921> > > >>>>>>> [2] https://issues.apache.org/jira/browse/IGNITE-4114 < > > >>>> https://issues.apache.org/jira/browse/IGNITE-4114> > > >>>>>>> > > >>>>>>> — > > >>>>>>> Denis > > >>>>>>> > > >>>>>>> On Nov 9, 2016, at 6:55 AM, Denis Magda <[email protected] > > <mailto: > > >>>> [email protected]>> wrote: > > >>>>>>> > > >>>>>>> Do we have a branch for ignite-1.8? Is there anyone who can take > > over > > >>>> the > > >>>>>>> release process of 1.8? > > >>>>>>> > > >>>>>>> — > > >>>>>>> Denis > > >>>>>>> > > >>>>>>> On Nov 8, 2016, at 9:01 PM, Alexander Paschenko < > > >>>>>>> [email protected] <mailto:alexander.a.paschenko@ > > >>>> gmail.com>> wrote: > > >>>>>>> > > >>>>>>> Current status on DML: > > >>>>>>> > > >>>>>>> - Basic data streamer support implemented (basicness is mostly > > about > > >>>>>>> configuration - say, currently there's no way to specify > streamer's > > >>>>>>> batch size via JDBC driver, but this can be improved easily). > > >>>>>>> > > >>>>>>> - Fixed all minor stuff agreed with Vladimir. > > >>>>>>> > > >>>>>>> - There are some tests that started failing after binary hash > codes > > >>>>>>> generation rework made by Vladimir in ignite-4011-1 branch, I > will > > ask > > >>>>>>> him to look into it and fix those. Failing tests live in > > >>>>>>> GridCacheBinaryObjectsAbstractSelfTest, and are as follows: > > >>>>>>> - testPutWithFieldsHashing > > >>>>>>> - testCrossFormatObjectsIdentity > > >>>>>>> - testPutWithCustomHashing > > >>>>>>> I added them personally during working on first version of auto > > >>>>>>> hashing few weeks ago, and what they do is test these very > hashing > > >>>>>>> features. Again, prior to Vlad's rework those tests passed. So > > could > > >>>>>>> you please take a look? > > >>>>>>> > > >>>>>>> - Working on Sergey V.'s comments about current code. > > >>>>>>> > > >>>>>>> - Alex > > >>>>>>> > > >>>>>>> > > >>>>>>> > > >>>>>>> > > >>>>>> > > >>>>> > > >>>>> > > >>>> > > >>>> > > > > >
