Aleksey, thanks! I answered in JIRA ticket.
On Mon, Mar 6, 2017 at 10:56 AM, ALEKSEY KUZNETSOV <alkuznetsov...@gmail.com> wrote: > I've fixed the comments. > http://reviews.ignite.apache.org/ignite/review/IGNT-CR-98 > > пт, 3 мар. 2017 г. в 19:23, Andrey Gura <ag...@apache.org>: > >> Aleksey, >> >> GitHub isn't official review tool in Apache Ignite community. There >> are two ways for code review: upsource and comments in JIRA tickets. >> So, I think, we should finish review of this ticket in upsource. >> >> On Thu, Mar 2, 2017 at 11:30 AM, ALEKSEY KUZNETSOV >> <alkuznetsov...@gmail.com> wrote: >> > lets review code at github rather than upsource later on. Because, the >> > later is too slow and bring no substantial benefits compared github >> > >> > ср, 1 мар. 2017 г. в 18:04, Andrey Gura <ag...@apache.org>: >> > >> >> Hi, Aleksey! >> >> >> >> Thank you for contribution! >> >> >> >> I've reviewed your changes and have some comments (mostly cosmetic). >> >> Could you please fix this comment? See review in Upsource for details. >> >> >> >> On Tue, Feb 28, 2017 at 2:17 PM, ALEKSEY KUZNETSOV >> >> <alkuznetsov...@gmail.com> wrote: >> >> > Plz, review my PR : >> >> > http://reviews.ignite.apache.org/ignite/review/IGNT-CR-98 >> >> > or https://github.com/apache/ignite/pull/1545 >> >> > -- >> >> > >> >> > *Best Regards,* >> >> > >> >> > *Kuznetsov Aleksey* >> >> >> > -- >> > >> > *Best Regards,* >> > >> > *Kuznetsov Aleksey* >> > -- > > *Best Regards,* > > *Kuznetsov Aleksey*
