Hi! Can u plz review ticket once more вт, 7 мар. 2017 г. в 18:52, Andrey Gura <[email protected]>:
> Aleksey, thanks a lot! > > Answered in JIRA ticket. > > On Tue, Mar 7, 2017 at 1:27 PM, ALEKSEY KUZNETSOV > <[email protected]> wrote: > > Hi! I have fixed all sources. Plz, review it again > > > > пн, 6 мар. 2017 г. в 15:43, Andrey Gura <[email protected]>: > > > >> Aleksey, thanks! > >> > >> I answered in JIRA ticket. > >> > >> On Mon, Mar 6, 2017 at 10:56 AM, ALEKSEY KUZNETSOV > >> <[email protected]> wrote: > >> > I've fixed the comments. > >> > http://reviews.ignite.apache.org/ignite/review/IGNT-CR-98 > >> > > >> > пт, 3 мар. 2017 г. в 19:23, Andrey Gura <[email protected]>: > >> > > >> >> Aleksey, > >> >> > >> >> GitHub isn't official review tool in Apache Ignite community. There > >> >> are two ways for code review: upsource and comments in JIRA tickets. > >> >> So, I think, we should finish review of this ticket in upsource. > >> >> > >> >> On Thu, Mar 2, 2017 at 11:30 AM, ALEKSEY KUZNETSOV > >> >> <[email protected]> wrote: > >> >> > lets review code at github rather than upsource later on. Because, > the > >> >> > later is too slow and bring no substantial benefits compared github > >> >> > > >> >> > ср, 1 мар. 2017 г. в 18:04, Andrey Gura <[email protected]>: > >> >> > > >> >> >> Hi, Aleksey! > >> >> >> > >> >> >> Thank you for contribution! > >> >> >> > >> >> >> I've reviewed your changes and have some comments (mostly > cosmetic). > >> >> >> Could you please fix this comment? See review in Upsource for > >> details. > >> >> >> > >> >> >> On Tue, Feb 28, 2017 at 2:17 PM, ALEKSEY KUZNETSOV > >> >> >> <[email protected]> wrote: > >> >> >> > Plz, review my PR : > >> >> >> > http://reviews.ignite.apache.org/ignite/review/IGNT-CR-98 > >> >> >> > or https://github.com/apache/ignite/pull/1545 > >> >> >> > -- > >> >> >> > > >> >> >> > *Best Regards,* > >> >> >> > > >> >> >> > *Kuznetsov Aleksey* > >> >> >> > >> >> > -- > >> >> > > >> >> > *Best Regards,* > >> >> > > >> >> > *Kuznetsov Aleksey* > >> >> > >> > -- > >> > > >> > *Best Regards,* > >> > > >> > *Kuznetsov Aleksey* > >> > > -- > > > > *Best Regards,* > > > > *Kuznetsov Aleksey* > -- *Best Regards,* *Kuznetsov Aleksey*
