Prachi, Thanks for creating the docs! Please leave your usability related feedback in this ticket [1]. I changed it’s priority targeting for 2.4 release because totally agree with you that presently the script doesn’t behave like a normal tool (no help page, meaningless log, etc.).
[1] https://issues.apache.org/jira/browse/IGNITE-6064 — Denis > On Oct 23, 2017, at 1:33 PM, Prachi Garg <pg...@gridgain.com> wrote: > > Guys, > > I have added the documentation for Cluster Activation - > https://apacheignite.readme.io/docs/cluster-activation > > While documenting, I noticed that the message printed on executing the > "control.sh --activate|deactivate" command is not giving me any useful > information. I can't tell if the cluster is active or not. > Similarly, the help message for "control.sh --help" is not very helpful :) > > -P > > On Tue, Aug 15, 2017 at 4:13 PM, Denis Magda <dma...@apache.org> wrote: > >> Add a documentation requirement. Ping me when the ticket is about to be >> closed. >> >> In the meanwhile, I’ll try to document the existing behavior. >> >> — >> Denis >> >>> On Aug 15, 2017, at 1:45 AM, Dmitriy Govorukhin < >> dmitriy.govoruk...@gmail.com> wrote: >>> >>> Folks, >>> >>> I created jira issue for the current discussion IGNITE-6064 >>> <https://issues.apache.org/jira/browse/IGNITE-6064>, leave you comment >>> please. >>> >>> On Tue, Aug 15, 2017 at 11:32 AM, Dmitriy Setrakyan < >> dsetrak...@apache.org> >>> wrote: >>> >>>> Added one more suggestion below. BTW, if there is no ticket, let's >> create >>>> one and copy all the suggestions there. >>>> >>>> On Tue, Aug 15, 2017 at 1:13 AM, Dmitriy Setrakyan < >> dsetrak...@apache.org> >>>> wrote: >>>> >>>>> Guys, >>>>> >>>>> Where is the ticket for adding control.[sh|bat] script to the bin >> folder? >>>>> I cannot find any mention of it. Was there a discussion on the dev >> list? >>>>> >>>>> Here are the issues I am seeing with the script: >>>>> >>>>> 1. It could be named better. Perhaps the name "cluster-ops" or >>>>> "cluster-switch" would be better. We should rename it in the next >>>> release. >>>>> 2. typing any bad command, e.g. "control bla" should provide a >>>>> standard usage message explaining correct syntax (see any other >>>> command >>>>> under bin folder) >>>>> 3. failure to connect to the cluster results in a long stack trace... >>>>> instead, it should provide a standard error message, suggesting >>>> possible >>>>> reasons for it. >>>>> >>>>> 4. Whenever trying to connect to a cluster, the script should print >> out a >>>> message "Connecting to ip-address:port ...". Otherwise, it looks like >> it is >>>> just hanging. >>>> >>>> >>>>> D. >>>>> >>>>> On Tue, Aug 15, 2017 at 12:59 AM, Dmitriy Govorukhin < >>>>> dmitriy.govoruk...@gmail.com> wrote: >>>>> >>>>>> Valentin, >>>>>> >>>>>> We have jira issue for this IGNITE-5586 >>>>>> <https://issues.apache.org/jira/browse/IGNITE-5586> >>>>>> >>>>>> On Tue, Aug 15, 2017 at 10:56 AM, Dmitriy Govorukhin < >>>>>> dmitriy.govoruk...@gmail.com> wrote: >>>>>> >>>>>>> >>>>>>> Denis, >>>>>>> >>>>>>> 1. control.sh have help parameter. If you try enter ./control.sh >>>> --help, >>>>>>> result is an example of how to use it, >>>>>>> "Example: --host {ip} --port {port} --{activate/deactivate} or >> without >>>>>>> command --host {ip} --port {port} then will print status" >>>>>>> >>>>>>> 2. Visorcmd will start daemon node and join in topology, it is quite >>>>>> long >>>>>>> time(as you know nodes joining in series) and requires resources. >>>>>>> Main goal was create some point for activation, fast and lightweight, >>>>>>> script does not start node. >>>>>>> >>>>>>> 3. Historically, the first name(control.sh - controls cluster >>>>>>> state active/inactive). Have any idea for another name? >>>>>>> >>>>>>> On Tue, Aug 15, 2017 at 2:25 AM, Valentin Kulichenko < >>>>>>> valentin.kuliche...@gmail.com> wrote: >>>>>>> >>>>>>>> Agree that this is confusing. I think this functionality should be a >>>>>> part >>>>>>>> of Visor CLI tool (likely a new command there). >>>>>>>> >>>>>>>> -Val >>>>>>>> >>>>>>>> On Mon, Aug 14, 2017 at 4:21 PM, Denis Magda <dma...@apache.org> >>>>>> wrote: >>>>>>>> >>>>>>>>> Dmitriy, >>>>>>>>> >>>>>>>>> I see you contributed control.sh script that activates a cluster >>>>>> after a >>>>>>>>> restart. Honestly, I’m a bit confused by it: >>>>>>>>> >>>>>>>>> 1. How to use it? I could find out that there are some of the >>>>>> parameters >>>>>>>>> but the ‘help’ is not implemented. Please fix this and provide a >>>>>>>>> description for every parameter you introduced. >>>>>>>>> >>>>>>>>> 2. Why did we decide to create a specific script for that? Why >>>> can’t >>>>>> we >>>>>>>>> use existing visorcmd script? >>>>>>>>> >>>>>>>>> 3. Why the script called “control.sh”? >>>>>>>>> >>>>>>>>> — >>>>>>>>> Denis >>>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>> >>>>> >>>> >> >>
