Agree, it is ok to merge, since we are waiting for the page replacement (eviction) performance fix anyway.
Spark data frames is a long-awaited feature by our users, so it does make sense to provide a complete support in 2.4. D. On Fri, Feb 9, 2018 at 2:55 PM, Denis Magda <dma...@apache.org> wrote: > +1 > > It wasn’t an undiscussed merge. The question was raised here before [1]. > > Anyway, Anton thanks for being on guard all the times! :) > > [1] http://apache-ignite-developers.2346864.n4.nabble. > com/Apache-Ignite-2-4-release-td26031i20.html#a26807 < > http://apache-ignite-developers.2346864.n4.nabble. > com/Apache-Ignite-2-4-release-td26031i20.html#a26807> > > — > Denis > > > On Feb 9, 2018, at 11:41 AM, Valentin Kulichenko < > valentin.kuliche...@gmail.com> wrote: > > > > I think it's OK to merge it to 2.4, especially since the release is > > delayed. This is a fairly small feature which is fully isolated from > > everything else, so there are no risks. At the same time, it makes data > > frames integration much more valuable. > > > > -Val > > > > On Fri, Feb 9, 2018 at 5:20 AM, Nikolay Izhikov <nizhi...@apache.org> > wrote: > > > >> Hello, Anton. > >> > >> I have no any objections. > >> > >> Seems like some kind of misunderstanding from my side. > >> > >> As far as I can understand mail from Dmitriy Setrakyan [1] He agreed to > >> include IGNITE-7337 to 2.4. > >> If the Ccommuntiy decides to postpone this feature in 2.5 release I'm > fully > >> OK with it. > >> > >> [1] > >> http://apache-ignite-developers.2346864.n4.nabble. > >> com/Apache-Ignite-2-4-release-tp26031p26807.html > >> > >> > >> 2018-02-09 14:58 GMT+03:00 Anton Vinogradov <a...@apache.org>: > >> > >>> Nikolay, > >>> > >>> 2.4 is almost ready to be released. > >>> We're fixing final issues to provide stable and fast release. > >>> Merging something to 2.4 except blockers is not possible at this phase > of > >>> release process. > >>> > >>> Hope, 2.5, with your changes, will be released soon :) > >>> > >>> On Fri, Feb 9, 2018 at 7:19 AM, Nikolay Izhikov <nizhi...@apache.org> > >>> wrote: > >>> > >>>> Hello, Igniters. > >>>> > >>>> Good news. > >>>> > >>>> IGNITE-7337 [1](Spark Data Frames: support saving a data frame in > >> Ignite) > >>>> are merged to master. > >>>> > >>>> For now we can both - read from and write to Ignite SQL table with > Data > >>>> Frame API. > >>>> Big thanks to Valentin Kulichenko for a quick review. > >>>> So it seems we can include this feature to 2.4 release. > >>>> > >>>> [1] https://issues.apache.org/jira/browse/IGNITE-7337 > >>> > >> > >
