I`ve finished with new module: https://github.com/apache/ignite/pull/3704
чт, 5 апр. 2018 г. в 12:06, Роман Меерсон <homich1...@gmail.com>: > Ok guys, I`ll made changes but what should we do with examples and with > Spring module version? > > Exemples couldn`t support both versions, so should i leave upgraded to 2.0 > version? > Spring module was upgraded to newest version, so should i leave it on > newest version? > > чт, 5 апр. 2018 г. в 0:17, Denis Magda <dma...@apache.org>: > >> Hi guys, >> >> According to ASF stats our spring data integration is 2 times more popular >> than spark integraion - 900 maven downloads vs. 400. >> >> So I would suggest us creating ignite-spring-data-2.0 module to support >> new >> deployments and leave ignite-spring-data to not break existing ones. >> >> -- >> Denis >> >> >> >> On Wed, Apr 4, 2018 at 7:33 AM, Dmitry Pavlov <dpavlov....@gmail.com> >> wrote: >> >> > Hi Igniters, >> > >> > I am going to review these changes in 3-4 days. If everything is ok and >> if >> > there is no objections, I will merge it. >> > >> > Hi Denis, >> > >> > are you agree with proposed change? >> > >> > Sincerely, >> > Dmitriy Pavlov >> > >> > ср, 4 апр. 2018 г. в 14:26, Дмитрий Рябов <somefire...@gmail.com>: >> > >> > > I agree that increasing complexity isn't good idea. Roman, can you >> > document >> > > the migration guide? >> > > >> > > 2018-04-04 13:41 GMT+03:00 Alexey Kukushkin < >> kukushkinale...@gmail.com>: >> > > >> > > > Roman, Dmitry, >> > > > >> > > > I also reviewed the fix and the code looks OK to me. But the fix has >> > > > significant implication - Ignite no longer can be used with >> spring-data >> > > 1.0 >> > > > due to no backward compatibility between spring 2.0 and 1.0 APIs. >> With >> > > this >> > > > approach we must remember to add corresponding spring-data migration >> > > > instructions to the future ignite 2.5 migration guide. >> > > > >> > > > We could keep spring 1 support and backward compatibility by >> creating a >> > > new >> > > > module "ignite-spring-2-data" and keeping existing >> ignite-spring-data >> > as >> > > > is. I do not like this option since to me increased complexity and >> > > > maintainability costs overweight the benefits of protecting >> > > > "Ignite-spring-1" users. >> > > > >> > > > I suggest you find a committer (see this list >> > > > <https://ignite.apache.org/community/resources.html#people>), >> > > communicate >> > > > the implication I mentioned above and say that two people already >> > > approved >> > > > the code providing we are OK with the chosen approach. >> > > > >> > > >> > >> >
