Dmitry, I confirm that a problem existed. Upsource can't handle situations of merging master to PR branch, in this case, Upsorce shows changes which are not related to a pull request.
I know only one workaround solution: rebasing branch on master and never merge it, but in this case, we lost mapping between existing comments and the commits in a pull request. On Fri, Apr 6, 2018 at 3:05 PM, Dmitry Pavlov <dpavlov....@gmail.com> wrote: > Hi Igniters, Anton, > > According to my experience upsource works well, except 1 suspicious case > with my PR. > > So I'm not sure if there are Upsource problems, probably there are problems > with some of our PRs? > > My example is https://github.com/apache/ignite/pull/3243 PR and > https://reviews.ignite.apache.org/ignite/review/IGNT-CR-513 ,- it is quite > old PR, so I can suppose it is some commit problem. > > Sinerely, > Dmitriy Pavlov > > пт, 6 апр. 2018 г. в 14:23, Anton Vinogradov <a...@apache.org>: > >> Igniters. >> >> Who is responsible for Upsource [1]? >> I see some strange things at reviews, a lot of fake changes inside reviews. >> I don't see such changes at PRs. >> Could you please check we're using stable version and update if necessary? >> >> >> [1] https://reviews.ignite.apache.org >> -- Best Regards, Vyacheslav D.
