Thank you, Roman. Igniters,
IMO we should consider one more alternative - renaming of old module and package names. Users, which prefer to stay on previous version will be requiered to update their pom's. In the same time users which are ready to migrate to spring data 2.0 will need to update methods naming. Denis M, what would you say? Sincerely, Dmitriy Pavlov вт, 10 апр. 2018 г. в 11:27, Роман Меерсон <[email protected]>: > Hi Dmitry! > > I`ve just commited new fix. I renamed package of new module to > springdata20, it helps us to separate old implementation from new and also > should fix all compilation errors. > > пн, 9 апр. 2018 г. в 23:54, Роман Меерсон <[email protected]>: > >> Ok, I'll check it, but I haven't face this problem. >> If I'll find same issue, what is the proper way? Renaming to something >> like Ignite2QueryGenerator or module removing? >> пн, 9 апр. 2018 г. в 23:40, Dmitry Pavlov <[email protected]>: >> >>> There are 2 classes IgniteQueryGenerator with same package name. Ignite >>> in Idea can't compile. >>> >>> >>> пн, 9 апр. 2018 г., 21:38 Роман Меерсон <[email protected]>: >>> >>>> Hi Dmitry! >>> >>> >>>> Could you specify where you find conflict? Because I don’t have any. >>>> пн, 9 апр. 2018 г. в 21:09, Dmitry Pavlov <[email protected]>: >>>> >>>>> Hi Denis, >>>>> >>>>> could we support just one version instead of leaving compatible module? >>>>> >>>>> Sincerely, >>>>> Dmitriy Pavlov >>>>> >>>>> пн, 9 апр. 2018 г. в 20:08, Dmitry Pavlov <[email protected]>: >>>>> >>>>>> >>>>>> >>>>>> пн, 9 апр. 2018 г. в 20:07, Dmitry Pavlov <[email protected]>: >>>>>> >>>>>>> Hi Roman, >>>>>>> >>>>>>> I've applied PR locally and I have class name conflict at least for >>>>>>> org.apache.ignite.springdata.repository.query.IgniteQueryGenerator >>>>>>> >>>>>>> How could we solve it? Is it better to rename class for new plugin >>>>>>> version? >>>>>>> >>>>>>> Sincerely, >>>>>>> Dmitriy Pavlov >>>>>>> >>>>>>> пт, 6 апр. 2018 г. в 17:38, Dmitry Pavlov <[email protected]>: >>>>>>> >>>>>>>> Excellend picture. I remember about this change. >>>>>>>> >>>>>>>> If Denis M. would be able to look througt the changes faster than >>>>>>>> me, I can merge without detailed review. >>>>>>>> >>>>>>>> пт, 6 апр. 2018 г. в 16:15, Роман Меерсон <[email protected]>: >>>>>>>> >>>>>>>>> OK >>>>>>>>> >>>>>>>>> [image: 1486924635147168240.jpg] >>>>>>>>> >>>>>>>>> >>>>>>>>> пт, 6 апр. 2018 г. в 17:08, Igor Sapego <[email protected]>: >>>>>>>>> >>>>>>>>>> Hi, >>>>>>>>>> Well, Dmitry has said he's going to merge it in 3-4 days 2 days >>>>>>>>>> ago, >>>>>>>>>> so I guess, the merge is going to happen in 1-2 days or so. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Best Regards, >>>>>>>>>> Igor >>>>>>>>>> >>>>>>>>>> On Fri, Apr 6, 2018 at 3:48 PM, Роман Меерсон < >>>>>>>>>> [email protected]> wrote: >>>>>>>>>> >>>>>>>>>> > Hi all! >>>>>>>>>> > >>>>>>>>>> > As i see everything is awesome and there is no objections, so >>>>>>>>>> when my PR >>>>>>>>>> > would be merged? >>>>>>>>>> > >>>>>>>>>> > чт, 5 апр. 2018 г. в 18:58, Вячеслав Коптилин < >>>>>>>>>> [email protected]>: >>>>>>>>>> > >>>>>>>>>> > > Thank you, Roman! >>>>>>>>>> > > >>>>>>>>>> > > 2018-04-05 17:49 GMT+03:00 Роман Меерсон < >>>>>>>>>> [email protected]>: >>>>>>>>>> > > >>>>>>>>>> > > > Hi Slava, >>>>>>>>>> > > > >>>>>>>>>> > > > Fixed >>>>>>>>>> > > > >>>>>>>>>> > > > чт, 5 апр. 2018 г. в 18:41, Вячеслав Коптилин < >>>>>>>>>> > [email protected] >>>>>>>>>> > > >: >>>>>>>>>> > > > >>>>>>>>>> > > > > Hi Roman, >>>>>>>>>> > > > > >>>>>>>>>> > > > > please take into account my comment >>>>>>>>>> IgniteQueryGenerator.java >>>>>>>>>> > > > > < >>>>>>>>>> > > > > >>>>>>>>>> https://reviews.ignite.apache.org/ignite/review/IGNT-CR-541? >>>>>>>>>> > > > commentId=de43c65f-9ac7-4080-9904-aec119138c94&filePath=/ >>>>>>>>>> > > > modules/spring-data-2.0/src/main/java/org/apache/ignite/ >>>>>>>>>> > > > springdata/repository/query/IgniteQueryGenerator.java >>>>>>>>>> > > > > > >>>>>>>>>> > > > > >>>>>>>>>> > > > > Best regards, >>>>>>>>>> > > > > Slava. >>>>>>>>>> > > > > >>>>>>>>>> > > > > 2018-04-05 14:59 GMT+03:00 Роман Меерсон < >>>>>>>>>> [email protected]>: >>>>>>>>>> > > > > >>>>>>>>>> > > > > > Ok, so waiting for accept and commit >>>>>>>>>> > > > > > >>>>>>>>>> > > > > > чт, 5 апр. 2018 г. в 15:29, Alexey Kukushkin < >>>>>>>>>> > > > [email protected] >>>>>>>>>> > > > > >: >>>>>>>>>> > > > > > >>>>>>>>>> > > > > > > Roman, >>>>>>>>>> > > > > > > >>>>>>>>>> > > > > > > Just pay commiter's (Dmitry Pavlov will most likely >>>>>>>>>> commit your >>>>>>>>>> > > code) >>>>>>>>>> > > > > > > attention to include the new test suite to TeamCity >>>>>>>>>> > configuration. >>>>>>>>>> > > > > > > >>>>>>>>>> > > > > > >>>>>>>>>> > > > > >>>>>>>>>> > > > >>>>>>>>>> > > >>>>>>>>>> > >>>>>>>>>> >>>>>>>>>
