Hi Maxim, I think next step can be creation of Junit4/5 IgniteAbstractTest and/or IgniteTestRunner. Would you like to contribute this prototype?
Regarding TC run there is a number of suspicious tests (e.g. IgnitePdsNativeIoTestSuite2: IgniteUidAsConsistentIdMigrationTest.testNewStyleAlwaysSmallestNodeIndexIsCreatedMultithreaded (fail rate 0,0%) & IgniteCacheTestSuite6: TxRollbackAsyncNearCacheTest.testSynchronousRollback (fail rate 0,0%) ) and a number of timeouts ocurred, so I've retriggered re-run for failed tests - https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&branch_IgniteTests24Java8=pull%2F3844%2Fhead For IGNITE-8266 <https://issues.apache.org/jira/browse/IGNITE-8266> could you please create CR? Sincerely, Dmitriy Pavlov пт, 4 мая 2018 г. в 12:27, Maxim Muzafarov <maxmu...@gmail.com>: > Igniters, > > Recenly, we've pached Ingite testing framework to stop all started > instances after all test-cases completion by default. > Details of impelemtaion can be viewed here [1]. This change leads us to a > lot of boilerplate code. > > > 1) I've created issue [2] and prepared PR [3] which removes all this > boilerplate code. Most of these changes is about removing: > ``` > @Override protected void afterTestsStopped() throws Exception { > super.afterTestsStopped(); > stopAllGrids(); > } > ``` > All tests looks good here. I've double cheched all requiremets and now I > need your help with review and futher steps up to merge. > > Can anyone help me? > > > 2) I've created issue [4] and planning to clean rarely used methods related > to stopAllGrids(). > E.g. stopAllClients and stopAllServers methods from GridAbstactTest used > only once in whole project but they locates in the root class. > From my point of view, this will simplify for futher migration Ignite > project to JUnit 4/5 framework. > > What else can be done here? > Please, share your thoughts. > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-6842 > [2] https://issues.apache.org/jira/browse/IGNITE-8266 > [3] https://github.com/apache/ignite/pull/3844 > [4] https://issues.apache.org/jira/browse/IGNITE-8157 >
