Dmitriy, I agree that in normal mode we should stop and report that error according. I prefer to add ability skip records for offline mode.
On Wed, May 30, 2018 at 5:24 PM, Dmitriy Setrakyan <dsetrak...@apache.org> wrote: > Dmitriy, > > I think the behavior for offline and online iterator is fundamentally > different. I do not think it is OK to skip records during normal operation. > In my view, we should report an error and stop. However, when offline, it > is OK to report an error and continue in my view. > > D. > > On Wed, May 30, 2018 at 5:39 AM, Dmitriy Govorukhin < > dmitriy.govoruk...@gmail.com> wrote: > > > Yakov, > > > > This problem is not for offline only, it applicable for all types of the > > iterators. > > In general, iterator does not know which class will be needed for > > deserialization. > > > > I guess we can expand WAL Iterator factory and provide a method for > > creating the iterator with some filter, > > which will accept predicate for skipping no interesting records. It will > > fix 1 problem. > > > > > > On Wed, May 30, 2018 at 3:18 PM, Yakov Zhdanov <yzhda...@apache.org> > > wrote: > > > > > This is for offline WAL analysis. So skipping record with proper > message > > is > > > also a solution. If it is possible, iterator should output a suggestion > > on > > > what is missing in classpath. Option to suppress warnings should also > > > present. > > > > > > Makes sense? > > > > > > And final question - did we look at similar utilities from other > vendors? > > > > > > --Yakov > > > > > >
