Dmitriy, Sorry, my mistake, I meant unknown exception of course.
On Sun, Jun 3, 2018 at 11:53 PM, Dmitriy Setrakyan <dsetrak...@apache.org> wrote: > I got a bit confused by your initial statement. So, the iterator is stopped > in case of any exception, known or unknown. In that case, sounds good. > > D. > > On Sun, Jun 3, 2018, 12:11 Dmitriy Govorukhin < > dmitriy.govoruk...@gmail.com> > wrote: > > > Dmitriy, > > > > The iterator will be stopped. and method "it.next()" will throw the > > exception. > > > > On Sat, Jun 2, 2018 at 4:27 PM, Dmitriy Setrakyan <dsetrak...@apache.org > > > > wrote: > > > > > Dmitriy, what happens in case of unknown exceptions? > > > > > > > > > On Thu, May 31, 2018 at 6:35 AM, Dmitriy Govorukhin < > > > dmitriy.govoruk...@gmail.com> wrote: > > > > > > > Folks, > > > > > > > > I created the issue to solve this issue. > > > > > > > > IGNITE-8661 <https://issues.apache.org/jira/browse/IGNITE-8661> > > > > WALItreater > > > > is not stopped if can not deserialize record > > > > > > > > I suggest to make the following changes: > > > > 1. We should only stop iteration on known exceptions > > > > 2. Also, need to provide ability skip records by type or some pointer > > for > > > > the StandaloneWalRecordsIterator > > > > > > > > Comments are welcome. > > > > > > > > On Thu, May 31, 2018 at 12:53 AM, Dmitriy Setrakyan < > > > dsetrak...@apache.org > > > > > > > > > wrote: > > > > > > > > > On Wed, May 30, 2018 at 8:04 AM, Dmitriy Govorukhin < > > > > > dmitriy.govoruk...@gmail.com> wrote: > > > > > > > > > > > Dmitriy, > > > > > > > > > > > > I agree that in normal mode we should stop and report that error > > > > > according. > > > > > > I prefer to add ability skip records for offline mode. > > > > > > > > > > > > > > > > Sounds good. > > > > > > > > > > > > > > >
