Hi Maxim, Thank you for your efforts to finding this out. I also didn't find any usages, so I agree here.
I'm going to commit this by lazy consensus if no-one objects within the next three days. Sincerely, Dmitriy Pavlov чт, 5 июл. 2018 г. в 12:56, Maxim Muzafarov <maxmu...@gmail.com>: > Hello everyone, > > Suppose clientEventChange method is useless and have confusing name. > > I'm suggesting to remove it as not used. I've filed issue for it: > > https://issues.apache.org/jira/browse/IGNITE-8936 > > > чт, 28 июн. 2018 г. в 16:53, Maxim Muzafarov <maxmu...@gmail.com>: > > > Hi Igniters, > > > > Recently I've faced with AffinityAssignment.clientEventChange() method > and > > not completly sure about the range of its applicability. The javadoc says > > "return {@code True} if related discovery event did not cause affinity > > assignment change and this assignment is just reference to the previous > > one." > > > > Three facts about it: > > 1) Method is the part of internal Ignite API > > 2) It is not used anywhere in Ignite project code > > 3) "clientEventChage" confusing name for this method. "true" value can be > > set not only by client-related events (e.g. cacheChangeRequest, > > affinityChangeRequest etc.). > > > > I've prepared diagram when it has "TRUE" value [1]. > > > > * Question #1 * When and for what cases we can use returned value of this > > method? > > * Question #2 * Can it be removed? My suggestion is to keep internal API > > as simple as possible. > > > > > > [1] https://image.ibb.co/cW6Mx8/Client_Event_Change_1.png > > >
