Fixed that.
> On 20 Feb 2019, at 14:50, Stepan Pilschikov <pilshchikov....@gmail.com> wrote: > > Denis, Dmitry > > Found that https://issues.apache.org/jira/browse/IGNITE-9922 > Release process just do not copy this folder > And this directory do not copy because of Dmitry concerns described earlier > > Agreed with Denis that examples folder should be in release build because > of: > - they really help to understand how client work > - they understandable enough even without documentation > - actually they contain link on examples documentation on readthedocs.io > - others clients have common structure (examples, lib, README.md, artifacts > to install package) but python client have not > > Dmitry talk about PyPI package which is should not contain any redundant > files and i agreed with him > But Denis talk only about apache-ignite release build binaries > > Also found https://issues.apache.org/jira/browse/IGNITE-10683 > Don't know how new folder is affected on release procedure of PyPi package > because ignite do not have fully automated pypi package release process, i > told only about release binaries > > I've open new ticket to add examples in release build: > https://issues.apache.org/jira/browse/IGNITE-11366 > > Dmitry, if you have any objections or improvements for this process you can > described theys in ticket > > чт, 14 февр. 2019 г. в 21:21, Denis Magda <dma...@apache.org>: > >> Dmitry, >> >> Thanks for looking into this. I think that something went wrong with our >> release procedure and we forgot to include the "examples" folder in Ignite >> binary package. Sergey K. is checking the release procedures. >> >> >> - >> Denis >> >> >> On Tue, Feb 12, 2019 at 7:28 PM Dmitry Melnichuk < >> dmitry.melnic...@nobitlost.com> wrote: >> >>> We just browse through the contents of the latest Ignite bundles [1]. >>> >>> Source bundle [2] contains the examples all right; they are in this >>> folder: >>> >>> /apache-ignite-2.7.0-src/modules/platforms/python/examples/ >>> >>> Binary bundle [3] do not contain examples. I'm not totally sure, but >>> the reasoning I gave earlier might apply to binary bundle too. >>> >>> Can anyone who's aware of the bundling procedure/scripts chime in, >>> please? >>> >>> [1] https://ignite.apache.org/download.cgi >>> >>> [2] >>> >>> >> http://mirrors.standaloneinstaller.com/apache//ignite/2.7.0/apache-ignite-2.7.0-src.zip >>> >>> [3] >>> >>> >> http://mirrors.standaloneinstaller.com/apache//ignite/2.7.0/apache-ignite-2.7.0-bin.zip >>> >>> On Wed, 2019-02-13 at 12:49 +1000, Dmitry Melnichuk wrote: >>>> Denis, >>>> >>>> If by “release procedure” you mean the contents of the PyPI package, >>>> then it is not a bug, but a deliberate decision, that was documented >>>> in >>>> README [1]: >>>> >>>>> Installation >>>>> ------------ >>>>> - for end user >>>>> >>>>> If you only want to use the pyignite module in your project, do: >>>>> >>>>> $ pip install pyignite >>>>> >>>>> -- for developer >>>>> >>>>> If you want to run tests, examples or build documentation, clone >>>>> the >>>>> whole repository… >>>> >>>> The reasoning: >>>> >>>> 1. The examples do not have much value by themselves. They are useful >>>> only in conjunction with the documentation. If we do not ship the >>>> documentation via PyPI, then we should not ship the examples either. >>>> >>>> 2. In production environment, the extra packaged stuff like examples >>>> will be just a waste of space. >>>> >>>> 3. Most Python libraries and frameworks I know of, e.g. Django or >>>> Scrapy, use the same approach: they have examples and test apps in >>>> the >>>> repository and reference them through their docs, but do not ship >>>> them >>>> via PyPI. >>>> >>>> [1] >>>> >>> >> https://github.com/apache/ignite/tree/master/modules/platforms/python#installation >>>> >>>> On Tue, 2019-02-12 at 16:23 -0800, Denis Magda wrote: >>>>> Igniters, >>>>> >>>>> Seems python examples were not added to the release bundle? >>>>> >>> >> https://apacheignite.readme.io/v2.7/docs/python-thin-client#section-running-an-example >>>>> >>>>> There is no "examples" folder for Python. Any flaws in the release >>>>> procedure? >>>>> >>>>> - >>>>> Denis >>> >>> >>
