Maxim, Good idea. I'd add a license check as well.
On Tue, Apr 14, 2020 at 2:14 AM Maxim Muzafarov <mmu...@apache.org> wrote: > Igniters, > > It's really `must-have` feature for me to enable Apache Ignite > pull-request status checks on GitHub. Currently we don't have any of > them. The most obvious check for each pull-request is: > - build the source code and check code-style violations; > > This will give us some advantages. For instance: > 1. Each PR even a very simple (not require tests execution) will be > checked by checkstyle and for compile errors. > 2. Developers can be get notified earlier if checkstyle has been > violated in their PRs. > > To achieve this we can do the following: > 1. Configure our TeamCity integration with the Ignite GitHub > repository and PR build. It seems it is possible [2]. > 2. Use Travis-ci which is free for open-source projects and also has > an integration with GitHub checks [1]. > > > What do you think? > What options will be the best for us? > > [1] > https://blog.travis-ci.com/2018-05-07-announcing-support-for-github-checks-api-on-travis-ci-com > [2] > https://himynameistim.com/2018/01/16/adding-build-statuses-to-pull-requests-with-teamcity-and-github/ > -- Best regards, Andrey V. Mashenkov
