Folks, I forgot to mention one more important thing of this tool. We can configure build and checks simultaneously for several JDK versions.
jdk: - oraclejdk8 - openjdk10 - openjdk11 On Tue, 14 Apr 2020 at 17:17, Maxim Muzafarov <mmu...@apache.org> wrote: > > Folks, > > +1 Travis-ci > > I see no disadvantages of having multiple CI tools due to: > - it's free for open-source and can be disabled at any time without > any consequences; > - it will free TeamCity from running builds on each PR and TC can > focus on tests execution; > - we can perform more sophisticated checks with this tool like a PR > title format (e.g. IGNITE-XXXXX: Sample) > > It seems the TC.Bot can also be integrated with GitHub checks via REST API > [1]. > > > I've checked locally the Ignite build procedure with travis-ci and > GitHub checks [2] and looks like everything is working fine. > Who can configure the similar things on Apache Ignite GitHub mirror? > Does anyone have such access rights? > > > [1] https://developer.github.com/v3/checks/runs/ > [2] https://github.com/Mmuzaf/ignite/pull/1/checks?check_run_id=584537955 > > On Tue, 14 Apr 2020 at 10:37, Nikolay Izhikov <nizhi...@apache.org> wrote: > > > > > On another hand, it seems weird to have both TeamCity and Travis > > > > And don’t forget MTCGA bot! > > > > > > > 14 апр. 2020 г., в 10:23, Pavel Tupitsyn <ptupit...@apache.org> > > > написал(а): > > > > > > We should have PR checks for sure. > > > > > > On one hand, I agree with Denis: > > > - Travis is very easy to set up in GitHub > > > - Config file (travis.yml) is stored in git, which is great > > > > > > On another hand, it seems weird to have both TeamCity and Travis. > > > Thoughts? > > > > > > On Tue, Apr 14, 2020 at 10:16 AM Denis Garus <garus....@gmail.com> wrote: > > > > > >> Hello! > > >> > > >> I have seen projects with Travis-ci they look cool. > > >> I think Travis-ci is a good solution. > > >> > > >> вт, 14 апр. 2020 г. в 10:00, Andrey Mashenkov <andrey.mashen...@gmail.com > > >>> : > > >> > > >>> Maxim, > > >>> > > >>> Good idea. I'd add a license check as well. > > >>> > > >>> On Tue, Apr 14, 2020 at 2:14 AM Maxim Muzafarov <mmu...@apache.org> > > >> wrote: > > >>> > > >>>> Igniters, > > >>>> > > >>>> It's really `must-have` feature for me to enable Apache Ignite > > >>>> pull-request status checks on GitHub. Currently we don't have any of > > >>>> them. The most obvious check for each pull-request is: > > >>>> - build the source code and check code-style violations; > > >>>> > > >>>> This will give us some advantages. For instance: > > >>>> 1. Each PR even a very simple (not require tests execution) will be > > >>>> checked by checkstyle and for compile errors. > > >>>> 2. Developers can be get notified earlier if checkstyle has been > > >>>> violated in their PRs. > > >>>> > > >>>> To achieve this we can do the following: > > >>>> 1. Configure our TeamCity integration with the Ignite GitHub > > >>>> repository and PR build. It seems it is possible [2]. > > >>>> 2. Use Travis-ci which is free for open-source projects and also has > > >>>> an integration with GitHub checks [1]. > > >>>> > > >>>> > > >>>> What do you think? > > >>>> What options will be the best for us? > > >>>> > > >>>> [1] > > >>>> > > >>> > > >> https://blog.travis-ci.com/2018-05-07-announcing-support-for-github-checks-api-on-travis-ci-com > > >>>> [2] > > >>>> > > >>> > > >> https://himynameistim.com/2018/01/16/adding-build-statuses-to-pull-requests-with-teamcity-and-github/ > > >>>> > > >>> > > >>> > > >>> -- > > >>> Best regards, > > >>> Andrey V. Mashenkov > > >>> > > >> > >
