I think, that we should enable checkstyle profile by default. Checkstyle should run even before compile lifecycle, may be on process-source. Codestyle problem should be handled immediately, but not on quite expensive TC run.
пн, 6 июл. 2020 г. в 20:34, Maxim Muzafarov <mmu...@apache.org>: > Hello Ilya, > > Why do you think that splitting the checkstyle build is better option > than fixing code style issues reporting by the checkstyle plugin? > > On Mon, 6 Jul 2020 at 19:43, Ilya Kasnacheev <ilya.kasnach...@gmail.com> > wrote: > > > > Hello! > > > > I have just noticed today that Checkstyle will fail Apache Ignite build: > > > https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_BuildApacheIgnite/5443282?buildTab=log&focusLine=3&linesState=683.4289 > > > > This means that I have completely lost an option to run tests against > pull > > requests by new contributors - they usually compile but will not pass > > Checkstyle. That's a blocker. > > > > Can we please split Checkstyle as a separate build which is triggered > with > > Run All? > > I think we even have > > > https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_CheckCodeStyle?mode=builds#all-projects > > > > WDYT? > > > > Regards, > > -- > > Ilya Kasnacheev > -- Sincerely yours, Ivan Daschinskiy
