All checks just force rules we agreed on. > Why this check is so important? Why do you think it is more important than > all other tasks/tests?
Because any code style violations should be fixed before the merge. Therefore after the fix, you must rerun TC. This means that running heavy suites when code style is violated is a waste of the resources. Why do you want to violate code style rules in your PR? I think instead of hiding style errors we should make our code style comfortable for everyone. Can you, please, write - what part of the code style hurts you? > 7 июля 2020 г., в 10:39, Вячеслав Коптилин <[email protected]> > написал(а): > > Hello Maxim, > >> Why do you think that splitting the checkstyle build is better option > than fixing code style issues reporting by the checkstyle plugin? > Why do you think that Ilya talks that code style errors should not be fixed? > > It looks weird to me that we do not even start the tests if check style > plugin reports violations. > Why can't this check be done in parallel with the tests and reported by > mtcga bot? > Why this check is so important? Why do you think it is more important than > all other tasks/tests? > > Thanks, > Slava. > > пн, 6 июл. 2020 г. в 20:34, Maxim Muzafarov <[email protected]>: > >> Hello Ilya, >> >> Why do you think that splitting the checkstyle build is better option >> than fixing code style issues reporting by the checkstyle plugin? >> >> On Mon, 6 Jul 2020 at 19:43, Ilya Kasnacheev <[email protected]> >> wrote: >>> >>> Hello! >>> >>> I have just noticed today that Checkstyle will fail Apache Ignite build: >>> >> https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_BuildApacheIgnite/5443282?buildTab=log&focusLine=3&linesState=683.4289 >>> >>> This means that I have completely lost an option to run tests against >> pull >>> requests by new contributors - they usually compile but will not pass >>> Checkstyle. That's a blocker. >>> >>> Can we please split Checkstyle as a separate build which is triggered >> with >>> Run All? >>> I think we even have >>> >> https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_CheckCodeStyle?mode=builds#all-projects >>> >>> WDYT? >>> >>> Regards, >>> -- >>> Ilya Kasnacheev >>
