-0 for both proposals
I agree with Ivan Daschinsky, we should not mix both approaches (interfaces
with "public" keyword and without "public" keyword), but I see no big
difference between "require public keyword in interfaces" rule and
"prohibit public keyword in interfaces" rule. To switch from one rule to
another we should change thousands of lines of code, this can produce a lot
of merge conflicts (for tickets currently in development). But what for?
What are the benefits? After the switch, some "old style" code will
certainly leak to the codebase, so also a new automatic checkstyle plugin
rule will be required to avoid "new style" violations.
The same for one line statements.
> do we have an automatic inspection for it? AFAIK we don't
We have the Apache Ignite code-style plugin for IDEA, where both of these
rules are checked.
> There were a few bugs that this rule caused.
Personally, I don't remember any, but I guess these bugs were caused by
wrong indent, but not the "one line statement" rule itself (as far as I
remember, once I saw such a wrong ident after one line statement in our
code). Perhaps it's better to add an automatic indent check if it's
possible.
ср, 21 июл. 2021 г. в 11:11, ткаленко кирилл <tkalkir...@yandex.ru>:
> +1
>
> 20.07.2021, 23:06, "Юрий" <jury.gerzhedow...@gmail.com>:
> > I totally agree.
> > Let's get rid of them.
> >
> > вт, 20 июл. 2021 г. в 18:11, Konstantin Orlov <kor...@gridgain.com>:
> >
> >> + for both
> >>
> >> --
> >> Regards,
> >> Konstantin Orlov
> >>
> >> > On 20 Jul 2021, at 16:32, Pavel Tupitsyn <ptupit...@apache.org>
> wrote:
> >> >
> >> > Agree with for both points
> >> >
> >> > On Tue, Jul 20, 2021 at 3:14 PM Alexander Polovtcev <
> >> alexpolovt...@gmail.com>
> >> > wrote:
> >> >
> >> >> this is a very welcome change for me
> >> >>
> >> >> On Tue, Jul 20, 2021 at 10:13 AM Ivan Pavlukhin <
> vololo...@gmail.com>
> >> >> wrote:
> >> >>
> >> >>> + for both points.
> >> >>>
> >> >>> 2021-07-20 9:56 GMT+03:00, Ivan Daschinsky <ivanda...@gmail.com>:
> >> >>>> Hi!
> >> >>>>
> >> >>>> Firstly, lets talk about interfaces.
> >> >>>>
> >> >>>> 1. First of all, do we have an automatic inspection for it? AFAIK
> we
> >> >>> don't
> >> >>>> 2. I am for consistency. At least for production code. Nothing
> worse
> >> is
> >> >>>> when someone mixes both approaches.
> >> >>>>
> >> >>>> About a prohibition of curly brackets around one line -- I am
> strongly
> >> >>>> against this rule, it should be removed. There were a few bugs
> that
> >> >> this
> >> >>>> rule caused.
> >> >>>>
> >> >>>> вт, 20 июл. 2021 г. в 09:23, Zhenya Stanilovsky
> >> >>> <arzamas...@mail.ru.invalid
> >> >>>>> :
> >> >>>>
> >> >>>>>
> >> >>>>> Igniters, i understand that this is very long and fundamental
> story.
> >> >> but
> >> >>>>> … still want to rise up this discussion, we have 2 very strange
> >> >>>>> inspections:
> >> >>>>> * «public» modifier in interface methods.
> >> >>>>> * Illegal ‘{}’ for one line statement. — i found it harmful.
> >> >>>>> I don`t want to link additional discussion about pos. 2 i think
> that
> >> >>> harm
> >> >>>>> is obvious.
> >> >>>>> I suggest to get rid of them.
> >> >>>>>
> >> >>>>> what do you think ?
> >> >>>>>
> >> >>>>>
> >> >>>>>
> >> >>>>
> >> >>>>
> >> >>>>
> >> >>>> --
> >> >>>> Sincerely yours, Ivan Daschinskiy
> >> >>>>
> >> >>>
> >> >>>
> >> >>> --
> >> >>>
> >> >>> Best regards,
> >> >>> Ivan Pavlukhin
> >> >>>
> >> >>
> >> >>
> >> >> --
> >> >> With regards,
> >> >> Aleksandr Polovtcev
> >> >>
> >
> > --
> > Живи с улыбкой! :D
>
