FrankKanBear commented on code in PR #10:
URL:
https://github.com/apache/ignite-nodejs-thin-client/pull/10#discussion_r3372386130
##########
src/Cursor.ts:
##########
@@ -27,7 +26,7 @@ import {CacheEntry} from "./CacheClient";
export abstract class BaseCursor<T> {
- protected _id: Long;
+ protected _id: any;
Review Comment:
Agreed — _id is genuinely a Long (this._id = buffer.readLong()) and it's
protected, so any leaks into the shipped dist/**.d.ts. Keeping the type via a
type-only import is the right fix: it erases at compile time (no runtime
require('long'), so the goal of dropping the value-import is preserved) and
keeps the declaration typed.
Suggestion on the _id line:
protected _id: Long;
And — since the PR removed const Long = require('long'); — re-add the
type-only import. Suggestion on the import BinaryUtils, { OPERATION } from
'./internal/BinaryUtils'; line:
import type Long from 'long';
import BinaryUtils, { OPERATION } from './internal/BinaryUtils';
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
