JohnSColeman commented on code in PR #10:
URL:
https://github.com/apache/ignite-nodejs-thin-client/pull/10#discussion_r3468501537
##########
src/internal/Logger.ts:
##########
@@ -41,4 +41,10 @@ export default class Logger {
console.log('ERROR: ' + data, ...args);
}
}
+
+ static logWarning(data: string, ...args: any[]) {
+ if (Logger._debug) {
+ console.log('WARNING: ' + data, ...args);
+ }
+ }
Review Comment:
Outdated — `logWarning` was introduced in an intermediate commit and removed
again in `92a22d6` when the unmatched-id path switched to fail-fast `throw`.
The final PR makes no net change to `Logger.ts` (it only defines
`logDebug`/`logError`), so there is no `console.log` vs `console.warn` choice
to revisit here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
