Hi Quanlong! I agree, it is better to cherry-pick the shell changes to branch-4.5.0 to follow semantic versioning. There was no other change in the shell since 4.5.0 than https://github.com/apache/impala/commit/9437f9fd1689320e74c71d61a8692d767fa0e073 The change above would have conflict due to bumping impyla version in the same commit. To fix this I would also cherry pick the previous bump: https://github.com/apache/impala/commit/6fc36b3e8ee5a46baea6bbcae09f4081a6ef028c
Csaba On Fri, Mar 21, 2025 at 9:07 AM Quanlong Huang <huangquanl...@gmail.com> wrote: > Hi Csaba, > > Thanks for raising this! > > The current master branch has some new features like IMPALA-12152. Can > we just cherry-pick some impala-shell commits to branch-4.5.0 and > release it as 4.5.1? If there are some critical bug fixes, we can also > pick them. > Then we are still following the Semantic versioning: > > Given a version number MAJOR.MINOR.PATCH, increment the: > - MAJOR version when you make incompatible API changes > - MINOR version when you add functionality in a backward compatible manner > - PATCH version when you make backward compatible bug fixes > > Regards, > Quanlong > > On Thu, Mar 20, 2025 at 4:50 AM Csaba Ringhofer > <csringho...@cloudera.com> wrote: > > > > Hi! > > > > I think that it is high time to create a new release for impala-shell on > > pypi - the main motivation is support for newer Python versions > > (IMPALA-12656) as with the current versions on pypi (4.4.0a2, 4.3.0) the > > newest Python that works is 3.10. > > https://pypi.org/project/impala-shell/#history > > > > Python 3.10 only gets security fixes and will be EOL in 2026. > > https://devguide.python.org/versions/ > > > > When Impala 4.5 was released the fix for newer Python versions was net > > merged yet, for this reason I don't think that it is useful to create an > > impala-shell release based on 4.5 state. > > > https://github.com/apache/impala/commit/9437f9fd1689320e74c71d61a8692d767fa0e073 > > > > My proposal is to create an impala-shell release based on the current > state > > of Apache Impala master branch and call it 4.5.1. This would be a shell > > only release. If there will be an Apache Impala hotfix release for 4.5 > than > > it would be 4.5.2. > > > > I don't see discussions about previous impala-shell releases in > dev-impala, > > but I though that it is better to discuss this openly due to the effect > on > > Apache Impala version number. > > > > There are several improvements besides Python compatibility since the > last > > non-alpha release 4.3.0, including: > > - OAuth AuthN support > > - "long polling" support > > - improved progress bar > > > > regards, > > Csaba >
