Casey Ching has posted comments on this change. Change subject: Get and use Kudu from the toolchain by default ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/1985/3/common/thrift/generate_error_codes.py File common/thrift/generate_error_codes.py: Line 214: ("KUDU_NOT_SUPPORTED_ON_OS", 69, "Kudu is not supported on this operating system.") > Yea, though we reserve the right to break it if necessary (i.e the 5.8 impa I wonder if adding some version detection would be worthwhile. Maybe if Kudu changes it's api version then Impala could fail fast. http://gerrit.cloudera.org:8080/#/c/1985/3/testdata/cluster/node_templates/cdh5/etc/init.d/kudu-common File testdata/cluster/node_templates/cdh5/etc/init.d/kudu-common: Line 1: if [[ -n $KUDU_BUILD_DIR ]]; then > adding it later would be the approach I would prefer, since I already had t Ok lets do a bulk update later. Line 5: if $USE_KUDU_DEBUG_BUILD; then > the new comment says "or USE_KUDU_DEBUG_BUILD" but should be "and", right? I think its right? If KUDU_BUILD_DIR is set then you dont need USE_KUDU_DEBUG_BUILD. If KUDU_BUILD_DIR isn't set then you need the other set. I could change it to "and" though that works too. -- To view, visit http://gerrit.cloudera.org:8080/1985 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3db88cbd27f2ea2394f011bc8d1face37411ed58 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
