Casey Ching has posted comments on this change.

Change subject: Get and use Kudu from the toolchain by default
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/1985/3/common/thrift/generate_error_codes.py
File common/thrift/generate_error_codes.py:

Line 214:   ("KUDU_NOT_SUPPORTED_ON_OS", 69, "Kudu is not supported on this 
operating system.")
> I wonder if adding some version detection would be worthwhile. Maybe if Kud
I was thinking about this more. Maybe it is better to disable Kudu support in 
the CDH release. It'll be clearer to users which version of Impala/Kudu they 
should use together. I'm guessing you are ok with that?


-- 
To view, visit http://gerrit.cloudera.org:8080/1985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3db88cbd27f2ea2394f011bc8d1face37411ed58
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Casey Ching <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to