Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3106: Don't allow scanner threads to spin before ranges are issued ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/2379/1/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: Line 214: // runtime filters to show up. i would still say this isn't a deliberate choice at this point but a compromise to avoid too much code churn (and there is really no reason to have started the scanner threads at this point). change comment to provide a bit more context (scanner threads have started, etc). Line 667: // to queue up a non-zero number of those splits to the io mgr (via the ScanNode). expand comment Line 1040: ranges_issued_barrier_.Wait(20, &timed_out); use declared constant -- To view, visit http://gerrit.cloudera.org:8080/2379 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I064de1ae037b578c70d65503895a920461af877a Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.5.0_5.7.0 Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
