Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-3106: Don't allow scanner threads to spin before ranges are issued ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2379/2/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: Line 1049: ranges_issued_barrier_.Wait(SCANNER_THREAD_WAIT_TIME_MS, &timed_out); If the HdfsScanNode::Open() returns before notifying, I think this thread will spin forever. Maybe you should remove the timed_out logic and just try to get a scan range. -- To view, visit http://gerrit.cloudera.org:8080/2379 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I064de1ae037b578c70d65503895a920461af877a Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.5.0_5.7.0 Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-HasComments: Yes
