Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor ......................................................................
Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/2203/10/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 1681: if (UNLIKELY(!parse_status_.ok())) continue_execution = false; > i'm not sure why the old code dropped query_status on the floor, but it mig It drops the status because specific non-OK query statuses are handled in ProcessSplit() (the checks after the AssembleRows() call). In addition, parse_status_ != query_status_. parse_status_ is set when something goes wrong with this scan in particular. Basically, AssembleRows() is not responsible for reporting a bad query status (outside of its own errors), but it does have to look at the query status to see if it should stop early. Lemme know if the above doesn't make sense, it's pretty subtle unfortunately. -- To view, visit http://gerrit.cloudera.org:8080/2203 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic70400407b7662999332448f4d1bce2cc344ca89 Gerrit-PatchSet: 10 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
