Sailesh Mukil has posted comments on this change. Change subject: IMPALA-2599: Pseudo-random sleep before acquiring kerberos ticket possibly not really pseudo-random. ......................................................................
Patch Set 1: (1 comment) > (1 comment) > > How did you test this? I ran it with the custom patch and logged the times that every impalad slept for. And they were always different. http://gerrit.cloudera.org:8080/#/c/2429/1/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: Line 514: uniform_int<> dist(0, 300); > should these three lines be moved out of the loop? It would give us more randomness every time if it stays within the loop. The generator is different every time it's initialized. Else dist(generator) would be the same every time. -- To view, visit http://gerrit.cloudera.org:8080/2429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I727a1b68aca43546bb79603b0ca83163ee169aa9 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
