Dan Hecht has posted comments on this change. Change subject: IMPALA-2599: Pseudo-random sleep before acquiring kerberos ticket possibly not really pseudo-random. ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/2429/1/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: Line 514: uniform_int<> dist(0, 300); > It would give us more randomness every time if it stays within the loop. Th Is that true? 'generator' should generate a pseudorandom sequence from the seed, not just a single random value. And since random_device may not have that many values (32-bit), it might give more randomness to use the sequence rather than re-seed. That said, in this case either should be fine. It just seemed a little more straight forward to have one generator to me. -- To view, visit http://gerrit.cloudera.org:8080/2429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I727a1b68aca43546bb79603b0ca83163ee169aa9 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
