Matthew Jacobs has posted comments on this change. Change subject: IMPALA-561: Allow multiple callbacks in a thread resource pool. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2430/1/be/src/runtime/thread-resource-mgr.cc File be/src/runtime/thread-resource-mgr.cc: Line 79: UpdatePoolQuotas > I am not so sure. In theory, if you have a high enough system_threads_quota It seems odd that registering a new pool should be the action that triggers the callbacks. It makes sense that ReleaseThreadToken() and UnregisterPool() would. When are these paths insufficient for the consumers of this code? The HdfsScanNode::ThreadTokenAvailableCb can spin up multiple threads (trying to acquire multiple tokens). -- To view, visit http://gerrit.cloudera.org:8080/2430 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddfff1feef0b59d407994ad3bc560166acbfa623 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
