Michael Ho has posted comments on this change. Change subject: IMPALA-561: Allow multiple callbacks in a thread resource pool. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2430/1/be/src/runtime/thread-resource-mgr.cc File be/src/runtime/thread-resource-mgr.cc: Line 79: UpdatePoolQuotas > It seems odd that registering a new pool should be the action that triggers I agree it seems odd to trigger callbacks on pool registration. I can definitely try the idea to not invoke callbacks on pool registration and see if anything is implicitly relying on it. That's a change in behavior and I am not too sure about the reasoning behind the original behavior. -- To view, visit http://gerrit.cloudera.org:8080/2430 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddfff1feef0b59d407994ad3bc560166acbfa623 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
