Skye Wanderman-Milne has posted comments on this change. Change subject: Specify whether to clone IR function in GetFunction() instead of ReplaceCallSites() ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2112/2/be/src/codegen/llvm-codegen.h File be/src/codegen/llvm-codegen.h: Line 532: /// bool is unused. > if bool is unused, why do we have it? Good question, looks like it can just be a set. I'll change it. -- To view, visit http://gerrit.cloudera.org:8080/2112 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8eabb5c062ee223c5de9df40aacfdc9dcda5ba63 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
