Hello Michael Ho, Dan Hecht, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2112
to look at the new patch set (#3).
Change subject: Specify whether to clone IR function in GetFunction() instead
of ReplaceCallSites()
......................................................................
Specify whether to clone IR function in GetFunction() instead of
ReplaceCallSites()
This patch changes the signature of LlvmCodegen::GetFunction() to
include whether a clone of the requested function should be returned,
and ReplaceCallSites() always modifies the input function
in-place. Before, ReplaceCallSites() could optionally clone the input
function.
Cloning the function in GetFunction() and occasionally via explicit
LlvmCodegen::CloneFunction() calls makes the logic easier to follow
and get right (for example, before we had cases where we were
unnecessarily cloning the function multiple times across multiple
ReplaceCallSites() calls).
Change-Id: I8eabb5c062ee223c5de9df40aacfdc9dcda5ba63
---
M be/src/codegen/codegen-anyval.cc
M be/src/codegen/llvm-codegen-test.cc
M be/src/codegen/llvm-codegen.cc
M be/src/codegen/llvm-codegen.h
M be/src/exec/aggregation-node.cc
M be/src/exec/hash-join-node.cc
M be/src/exec/hash-table.cc
M be/src/exec/hdfs-avro-scanner.cc
M be/src/exec/hdfs-scanner.cc
M be/src/exec/partitioned-aggregation-node.cc
M be/src/exec/partitioned-hash-join-node.cc
M be/src/exec/text-converter.cc
M be/src/exprs/expr.cc
13 files changed, 213 insertions(+), 222 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/12/2112/3
--
To view, visit http://gerrit.cloudera.org:8080/2112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8eabb5c062ee223c5de9df40aacfdc9dcda5ba63
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Skye Wanderman-Milne <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
