Sailesh Mukil has posted comments on this change. Change subject: IMPALA-2626: In-flight queries fail when statestore comes back online. ......................................................................
Patch Set 2: > My suggestion is that there's some way to tell whether a backend > was removed because it failed, or because the statestore restarted, > because in the former case you get a deletion notification, and in > the other it just stops showing up in the topic. Yes, but what if a node(s) goes down the same time as the statestore goes down? The statestore wouldn't send a deletion topic for that node(s) because it wouldn't know it existed and so the query would never get cancelled. Also, I would think that this could happen with a higher than negligible chance on larger clusters, so it's safer to be pessimistic in this case. -- To view, visit http://gerrit.cloudera.org:8080/1380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I102391ab63270a9686cf45457b8384ffcd2abe8a Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
