Henry Robinson has posted comments on this change. Change subject: IMPALA-2626: In-flight queries fail when statestore comes back online. ......................................................................
Patch Set 2: How does your patch handle that case? I think it waits for the next topic update that has some entries in it, and then computes the diff. Why not do the same thing: If the node has disappeared from the topic, but there has been no deletion event, wait for another topic update (or some number) before declaring the node dead. This generalises your current patch to handle the case where the topic update contains a partial update, and makes Impala a bit more robust to slow recovery from a statestore failure. -- To view, visit http://gerrit.cloudera.org:8080/1380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I102391ab63270a9686cf45457b8384ffcd2abe8a Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
