Michael Ho has posted comments on this change. Change subject: Reduce dependencies on inline header functions ......................................................................
Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/2485/3/be/src/runtime/decimal-value.inline.h File be/src/runtime/decimal-value.inline.h: Line 31: inline DecimalValue<T> DecimalValue<T>::FromDouble(int precision, int scale, double d, I wonder if all of these need to be in the header files. Can some of them be moved to decimal-operator.cc ? Line 307: } nit: missing blank lines. Same below. http://gerrit.cloudera.org:8080/#/c/2485/3/be/src/runtime/raw-value-ir.cc File be/src/runtime/raw-value-ir.cc: Line 16: nit: extra blank line. http://gerrit.cloudera.org:8080/#/c/2485/3/be/src/runtime/raw-value.inline.h File be/src/runtime/raw-value.inline.h: Line 32: inline bool RawValue::Eq(const void* v1, const void* v2, const ColumnType& type) { This looks pretty big. Should we inline it ? Same question for some functions below. http://gerrit.cloudera.org:8080/#/c/2485/3/be/src/runtime/timestamp-value.cc File be/src/runtime/timestamp-value.cc: Line 16: nit: extra blank line ? -- To view, visit http://gerrit.cloudera.org:8080/2485 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7a2f388cd14a4427c43af2724340a2ffe8fae3d Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
