Skye Wanderman-Milne has posted comments on this change. Change subject: Reduce dependencies on inline header functions ......................................................................
Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/2485/6/be/src/exprs/timestamp-functions.h File be/src/exprs/timestamp-functions.h: Line 112: static std::string ShortMonthName(FunctionContext* context, const TimestampVal& ts); How did it compiles without the std:: before? http://gerrit.cloudera.org:8080/#/c/2485/6/be/src/runtime/decimal-value.h File be/src/runtime/decimal-value.h: Line 55: static DecimalValue FromDouble(int precision, int scale, double d, bool* overflow); Mark inline? here and below http://gerrit.cloudera.org:8080/#/c/2485/6/be/src/runtime/runtime-filter.h File be/src/runtime/runtime-filter.h: Line 84: const RuntimeFilter* GetRuntimeFilter(uint32_t filter_id); Mark inline? here and below http://gerrit.cloudera.org:8080/#/c/2485/6/be/src/runtime/timestamp-parse-util.cc File be/src/runtime/timestamp-parse-util.cc: Line 17: #include <cstddef> Remove if unnececssary http://gerrit.cloudera.org:8080/#/c/2485/6/be/src/runtime/timestamp-parse-util.h File be/src/runtime/timestamp-parse-util.h: Line 163: static DateTimeFormatContext* CreateFormatContext(); You didn't actually delete these :) http://gerrit.cloudera.org:8080/#/c/2485/6/be/src/runtime/timestamp-test.cc File be/src/runtime/timestamp-test.cc: Line 16: #include <cstddef> Remove here too if unnecessary -- To view, visit http://gerrit.cloudera.org:8080/2485 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7a2f388cd14a4427c43af2724340a2ffe8fae3d Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
