Dan Hecht has posted comments on this change.

Change subject: IMPALA-3136: Use gutil SpinLock
......................................................................


Patch Set 4:

> (1 comment)
 > 
 > Do we want to review the spinlock implementation in detail? It
 > looks like it does what we want, but I havent' reviewed the
 > implementation in detail.

I don't think it's necessary.  I looked at it some, and kudu has been using it 
for a while now.  We can treat it more like a dependency (until we start 
changing it).

-- 
To view, visit http://gerrit.cloudera.org:8080/2507
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1e5322df1d5936ee9679cdc0031772b5f44b135
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Dan Hecht <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: No

Reply via email to