Tim Armstrong has posted comments on this change. Change subject: IMPALA-3136: Use gutil SpinLock ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/2507/6/be/src/gutil/atomicops-internals-x86.h File be/src/gutil/atomicops-internals-x86.h: Line 27: #include "common/logging.h" > Oops meant to say "warnings" not "errors" in the first sentence. NO reason, I just missed added it to the cross-compile. I made the same change in a different glog header for the same reason, so this should be ok. -- To view, visit http://gerrit.cloudera.org:8080/2507 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e5322df1d5936ee9679cdc0031772b5f44b135 Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
