Matthew Jacobs has posted comments on this change. Change subject: Make .gitignore work with thirdparty ......................................................................
Patch Set 2: (1 comment) Now might be a good time to decide if we can get rid of the non-java dependencies (well, everything not in native-toolchain). Let's see what Henry says. http://gerrit.cloudera.org:8080/#/c/2517/2/bin/impala-config.sh File bin/impala-config.sh: Line 321: "$IMPALA_HOME"/thirdparty/tarballs/extract_thirdparty.py Shouldn't this go towards the top of the file since we have stuff that reaches into thirdparty up there (e.g. l260)? -- To view, visit http://gerrit.cloudera.org:8080/2517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec5fe5b17950574977b202a44181bd7644bb77e Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
