Casey Ching has posted comments on this change. Change subject: Make .gitignore work with thirdparty ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2517/2/bin/impala-config.sh File bin/impala-config.sh: Line 321: "$IMPALA_HOME"/thirdparty/tarballs/extract_thirdparty.py > Shouldn't this go towards the top of the file since we have stuff that reac It's fine here but I'll move it anyways so there is no doubt. The stuff above doesn't actually need the paths to exist. I'm going to send a new review without all these stupid 3rd party files. -- To view, visit http://gerrit.cloudera.org:8080/2517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec5fe5b17950574977b202a44181bd7644bb77e Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
