Dan Hecht has posted comments on this change. Change subject: IMPALA-2069: add USE_UTF8_PARQUET_STRINGS query option ......................................................................
Patch Set 1: (1 comment) What would break if we made this the default behavior? http://gerrit.cloudera.org:8080/#/c/2531/1/be/src/exec/hdfs-parquet-table-writer.h File be/src/exec/hdfs-parquet-table-writer.h: Line 134: bool use_utf8_strings_; why not just use the query option directly? -- To view, visit http://gerrit.cloudera.org:8080/2531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I030c9f5c6272e09c1ce133f66234e3cfb26b68d4 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-HasComments: Yes
