Dan Hecht has posted comments on this change. Change subject: IMPALA-2069: add USE_UTF8_PARQUET_STRINGS query option ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/2531/2/be/src/service/query-options.h File be/src/service/query-options.h: Line 77: use_utf8_parquet_strings since this only controls whether strings are annotated (not whether we use them), how about calling it: parquet_annotate_strings_utf8, or similar? http://gerrit.cloudera.org:8080/#/c/2531/2/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: Line 168: // always use the annotation. please add that comment explaining why this is disabled by default. -- To view, visit http://gerrit.cloudera.org:8080/2531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I030c9f5c6272e09c1ce133f66234e3cfb26b68d4 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-HasComments: Yes
