Tim Armstrong has restored this change. Change subject: Inject precision and scale constants for all decimal builtins ......................................................................
Restored I'm going to restore this version. Skye had code a more elegant approach where we injected a constant TypeDesc struct. This led to more natural code, but the way LLVM handles returning structs by value is platform and implementation-specific (e.g. a struct with 4 int32s is returned as a struct with 2 int64s). This would lead to problems if LLVM changes its implementation or we want to support non-x86-64 platforms. -- To view, visit http://gerrit.cloudera.org:8080/2535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: restore Gerrit-Change-Id: I7b7d1485f357ba88517ca15c5c7428c0ffe25dfd Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]>
