Skye Wanderman-Milne has posted comments on this change. Change subject: Inject precision and scale constants for all decimal builtins ......................................................................
Patch Set 3: FWIW, LLVM is unlikely to change its implementation because it needs to remain x86_64 ABI compatible, and we're gonna run into this whenever we want to return non-primitive types in codegen'd code (we already manually do the lowering with Expr functions, which return AnyVal structs). We could do something like add #ifdef __x86_64 guards around these parts and fail the compilation otherwise to make this more friendly to porting to new architectures. I'm slightly in favor of injecting the TypeDesc, since I think we'll see this more and more as we codegen more, but I'm fine either way. -- To view, visit http://gerrit.cloudera.org:8080/2535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b7d1485f357ba88517ca15c5c7428c0ffe25dfd Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
